Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH] powerpc: powermac: Use of_get_cpu_hwid() to read CPU node 'reg' | Date | Tue, 15 Aug 2023 14:01:01 +1000 |
| |
Christophe JAILLET <christophe.jaillet@wanadoo.fr> writes: > Le 03/07/2023 à 07:26, Michael Ellerman a écrit : >> On Sun, 19 Mar 2023 09:59:31 -0500, Rob Herring wrote: >>> Replace open coded reading of CPU nodes' "reg" properties with >>> of_get_cpu_hwid() dedicated for this purpose. >>> >>> >> >> Applied to powerpc/next. >> >> [1/1] powerpc: powermac: Use of_get_cpu_hwid() to read CPU node 'reg' >> https://git.kernel.org/powerpc/c/bc1cf75027585f8d87f94e464ee5909acf885a8c >> >> cheers >> > > Hi, > > I guess, that it does not really matter, but shouldn't the > of_node_put() be *after* the "reset_io = *rst;" statements to be > absolutely safe?
Technically yes.
> (This change is in my backlog and I have apparently never proposed it)
Can you rebase and resend?
cheers
| |