Messages in this thread | | | Date | Mon, 3 Jul 2023 19:01:31 +0200 | Subject | Re: [PATCH] powerpc: powermac: Use of_get_cpu_hwid() to read CPU node 'reg' | From | Christophe JAILLET <> |
| |
Le 03/07/2023 à 07:26, Michael Ellerman a écrit : > On Sun, 19 Mar 2023 09:59:31 -0500, Rob Herring wrote: >> Replace open coded reading of CPU nodes' "reg" properties with >> of_get_cpu_hwid() dedicated for this purpose. >> >> > > Applied to powerpc/next. > > [1/1] powerpc: powermac: Use of_get_cpu_hwid() to read CPU node 'reg' > https://git.kernel.org/powerpc/c/bc1cf75027585f8d87f94e464ee5909acf885a8c > > cheers >
Hi,
I guess, that it does not really matter, but shouldn't the of_node_put() be *after* the "reset_io = *rst;" statements to be absolutely safe?
(This change is in my backlog and I have apparently never proposed it)
CJ
| |