Messages in this thread Patch in this message | | | From | coolrrsh@gmail ... | Subject | [PATCH] platform: sps: Fix an unsigned comparison that can | Date | Sun, 13 Aug 2023 16:31:22 +0530 |
| |
From: Rajeshwar R Shinde <coolrrsh@gmail.com>
The variable 'mode' is declared as unsigned int in local function. The return value of function amd_pmf_get_pprof_modes(dev) is int and it is stored in the 'mode' variable. Also the value of 'mode' variable is compared with 0 which is signed int by default. Thus redeclaring the variable to signed int.
This fixes warning such as: drivers/platform/x86/amd/pmf/sps.c:128:5-9: WARNING: Unsigned expression compared with zero: mode < 0
Signed-off-by: Rajeshwar R Shinde <coolrrsh@gmail.com> --- drivers/platform/x86/amd/pmf/sps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/amd/pmf/sps.c b/drivers/platform/x86/amd/pmf/sps.c index ab69d517a36a..703723a66830 100644 --- a/drivers/platform/x86/amd/pmf/sps.c +++ b/drivers/platform/x86/amd/pmf/sps.c @@ -176,7 +176,7 @@ int amd_pmf_get_pprof_modes(struct amd_pmf_dev *pmf) int amd_pmf_power_slider_update_event(struct amd_pmf_dev *dev) { - u8 mode, flag = 0; + int mode, flag = 0; int src; mode = amd_pmf_get_pprof_modes(dev); -- 2.25.1
| |