Messages in this thread | | | Date | Mon, 14 Aug 2023 07:58:54 +0800 | From | kernel test robot <> | Subject | drivers/spi/spi-mpc52xx-psc.c:195:5: warning: no previous prototype for 'mpc52xx_psc_spi_transfer_one_message' |
| |
Hi Mark,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 2ccdd1b13c591d306f0401d98dedc4bdcd02b421 commit: 145cfc3840e5931a789a8e2e76af841ab4cad44b spi: mpc52xx-psc: Switch to using core message queue date: 1 year, 2 months ago config: powerpc-randconfig-r032-20230814 (https://download.01.org/0day-ci/archive/20230814/202308140725.VrL4g7bu-lkp@intel.com/config) compiler: powerpc-linux-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230814/202308140725.VrL4g7bu-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202308140725.VrL4g7bu-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/spi/spi-mpc52xx-psc.c:195:5: warning: no previous prototype for 'mpc52xx_psc_spi_transfer_one_message' [-Wmissing-prototypes] 195 | int mpc52xx_psc_spi_transfer_one_message(struct spi_controller *ctlr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/mpc52xx_psc_spi_transfer_one_message +195 drivers/spi/spi-mpc52xx-psc.c
194 > 195 int mpc52xx_psc_spi_transfer_one_message(struct spi_controller *ctlr, 196 struct spi_message *m) 197 { 198 struct spi_device *spi; 199 struct spi_transfer *t = NULL; 200 unsigned cs_change; 201 int status; 202 203 spi = m->spi; 204 cs_change = 1; 205 status = 0; 206 list_for_each_entry (t, &m->transfers, transfer_list) { 207 if (t->bits_per_word || t->speed_hz) { 208 status = mpc52xx_psc_spi_transfer_setup(spi, t); 209 if (status < 0) 210 break; 211 } 212 213 if (cs_change) 214 mpc52xx_psc_spi_activate_cs(spi); 215 cs_change = t->cs_change; 216 217 status = mpc52xx_psc_spi_transfer_rxtx(spi, t); 218 if (status) 219 break; 220 m->actual_length += t->len; 221 222 spi_transfer_delay_exec(t); 223 224 if (cs_change) 225 mpc52xx_psc_spi_deactivate_cs(spi); 226 } 227 228 m->status = status; 229 if (status || !cs_change) 230 mpc52xx_psc_spi_deactivate_cs(spi); 231 232 mpc52xx_psc_spi_transfer_setup(spi, NULL); 233 234 spi_finalize_current_message(ctlr); 235 236 return 0; 237 } 238
-- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
| |