Messages in this thread Patch in this message | | | From | Bartosz Golaszewski <> | Subject | [PATCH 1/2] gpio: sim: simplify gpio_sim_device_config_live_store() | Date | Fri, 11 Aug 2023 15:14:26 +0200 |
| |
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Simplify the logic when checking the current live value against the user input.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> --- This is the same as what Andy suggested for gpio-consumer. Let's save a line.
drivers/gpio/gpio-sim.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c index dc4097dc0fbc..0177b41e0d72 100644 --- a/drivers/gpio/gpio-sim.c +++ b/drivers/gpio/gpio-sim.c @@ -986,8 +986,7 @@ gpio_sim_device_config_live_store(struct config_item *item, mutex_lock(&dev->lock); - if ((!live && !gpio_sim_device_is_live_unlocked(dev)) || - (live && gpio_sim_device_is_live_unlocked(dev))) + if (live == gpio_sim_device_is_live_unlocked(dev)) ret = -EPERM; else if (live) ret = gpio_sim_device_activate_unlocked(dev); -- 2.39.2
| |