Messages in this thread | | | Date | Fri, 11 Aug 2023 21:19:18 +0000 | Subject | [PATCH RFC 0/3] powerpc/ps3: refactor strncpy usage | From | Justin Stitt <> |
| |
Within this RFC-series I want to get some comments on two ideas that I have for refactoring the current `strncpy` usage in repository.c.
When looking at `make_first_field` we see a u64 is being used to store up to 8 bytes from a literal string. This is slightly suspect to me but it works? In regards to `strncpy` here, it makes the code needlessly complex imo.
Please see my two ideas to change this and let me know if any other approaches are more reasonable.
Link: https://github.com/KSPP/linux/issues/90 Signed-off-by: Justin Stitt <justinstitt@google.com> --- Justin Stitt (3): [RFC] powerpc/ps3: refactor strncpy usage attempt 1 [RFC] powerpc/ps3: refactor strncpy usage attempt 2 [RFC] powerpc/ps3: refactor strncpy usage attempt 2.5
arch/powerpc/platforms/ps3/repository.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) --- base-commit: 52a93d39b17dc7eb98b6aa3edb93943248e03b2f change-id: 20230811-strncpy-arch-powerpc-platforms-ps3-57a1cdb2ad9b
Best regards, -- Justin Stitt <justinstitt@google.com>
| |