lkml.org 
[lkml]   [2023]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] ext4: fix memory leak in ext4_fname_setup_filename() error path
Date
If casefolding the filename fails, we'll be leaking fscrypt_buf name.
Make sure we free it in the error path.

Signed-off-by: Luís Henriques <lhenriques@suse.de>
---
fs/ext4/crypto.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/fs/ext4/crypto.c b/fs/ext4/crypto.c
index e20ac0654b3f..9e4503b051c4 100644
--- a/fs/ext4/crypto.c
+++ b/fs/ext4/crypto.c
@@ -33,6 +33,8 @@ int ext4_fname_setup_filename(struct inode *dir, const struct qstr *iname,

#if IS_ENABLED(CONFIG_UNICODE)
err = ext4_fname_setup_ci_filename(dir, iname, fname);
+ if (err)
+ fscrypt_free_filename(&name);
#endif
return err;
}
\
 
 \ /
  Last update: 2023-08-01 16:41    [W:0.033 / U:0.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site