lkml.org 
[lkml]   [2023]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] gpio: rc5t583: remove unneeded call to platform_set_drvdata()
On Fri, Jul 28, 2023 at 8:20 PM Andrei Coardos <aboutphysycs@gmail.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
> drivers/gpio/gpio-rc5t583.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-rc5t583.c b/drivers/gpio/gpio-rc5t583.c
> index 4fae3ebea790..c34dcadaee36 100644
> --- a/drivers/gpio/gpio-rc5t583.c
> +++ b/drivers/gpio/gpio-rc5t583.c
> @@ -121,8 +121,6 @@ static int rc5t583_gpio_probe(struct platform_device *pdev)
> if (pdata && pdata->gpio_base)
> rc5t583_gpio->gpio_chip.base = pdata->gpio_base;
>
> - platform_set_drvdata(pdev, rc5t583_gpio);
> -
> return devm_gpiochip_add_data(&pdev->dev, &rc5t583_gpio->gpio_chip,
> rc5t583_gpio);
> }
> --
> 2.34.1
>

Applied, thanks!

Bartosz

\
 
 \ /
  Last update: 2023-08-01 21:28    [W:0.040 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site