Messages in this thread | | | Date | Mon, 31 Jul 2023 21:41:07 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH] nvme: Don't fail to resume if NSIDs change |
| |
On Mon, Jul 31, 2023 at 01:10:11PM -0600, Keith Busch wrote: > > As the check has been relaxed at startup for multiple disks with > > duplicate NSIDs with commit ac522fc6c3165 ("nvme: don't reject > > probe due to duplicate IDs for single-ported PCIe devices") also > > relax the check that runs on resume for NSIDs and mark them bogus > > if this occurs on resume. > > How could the driver tell the difference between the device needing a > quirk compared to a rapid delete-create-attach namespace sequence? > Proceeding with the namespace now may get dirty writes intended for the > previous namespace, corrupting the new one. > > The commit you mentioned tries to constrain allowing duplication where > we can reasonably assume the quirk is needed. If we need to do similiar > for this condition, one possible constraint might be that the device > doesn't report OACS bit 3 (Namespace Management).
Yes, this patch as-is looks really dangerous. I don't think we should just ignore the fact that IDs change when queried again.
| |