Messages in this thread | | | Date | Mon, 31 Jul 2023 21:11:39 +0200 | Subject | Re: [PATCH] nvme: Don't fail to resume if NSIDs change | From | August Wikerfors <> |
| |
On 2023-07-31 20:51, Mario Limonciello wrote: > Samsung PM9B1 has problems after resume because NSID has changed. > This has been reported in the past on OEM varities of PM9B1 parts > and fixed by firmware updates on 'some' of those parts. > > However this same issue also happens on 'retail' PM9B1 parts which > Samsung has not released firmware updates for. > > As the check has been relaxed at startup for multiple disks with > duplicate NSIDs with commit ac522fc6c3165 ("nvme: don't reject > probe due to duplicate IDs for single-ported PCIe devices") also > relax the check that runs on resume for NSIDs and mark them bogus > if this occurs on resume. > > Fixes: 1d5df6af8c74 ("nvme: don't blindly overwrite identifiers on disk revalidate") > Cc: stable@vger.kernel.org # 6.1+ > Cc: Nils Kruse <nilskruse97@gmail.com> > Cc: August Wikerfors <git@augustwikerfors.se> > Cc: David Chang <David.Chang@amd.com> > Link: https://github.com/tomsom/yoga-linux/issues/9 > Link: https://lore.kernel.org/linux-nvme/b99a5149-c3d6-2a9b-1298-576a1b4b22c1@gmail.com/ > Link: https://lore.kernel.org/all/20221116171727.4083-1-git@augustwikerfors.se/t/ > Link: https://lore.kernel.org/all/d0ce0f3b-9407-9207-73a4-3536f0948653@augustwikerfors.se/ > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Tested-by: August Wikerfors <git@augustwikerfors.se>
Thanks!
| |