Messages in this thread Patch in this message | | | From | Andy Shevchenko <> | Subject | [PATCH v2 1/2] mfd: ipaq-micro: Use %*ph for printing hexdump of a small buffer | Date | Mon, 3 Jul 2023 17:09:22 +0300 |
| |
The kernel already has a helper to print a hexdump of a small buffer via pointer extension. Use that instead of open coded variant.
In long term it helps to kill pr_cont() or at least narrow down its use.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- v2: split another change to a separate patch (Lee) drivers/mfd/ipaq-micro.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c index 6d3968458e81..cddfd2e808f2 100644 --- a/drivers/mfd/ipaq-micro.c +++ b/drivers/mfd/ipaq-micro.c @@ -131,10 +131,7 @@ static void micro_rx_msg(struct ipaq_micro *micro, u8 id, int len, u8 *data) break; default: dev_err(micro->dev, - "unknown msg %d [%d] ", id, len); - for (i = 0; i < len; ++i) - pr_cont("0x%02x ", data[i]); - pr_cont("\n"); + "unknown msg %d [%d] %*ph\n", id, len, len, data); } spin_unlock(µ->lock); } -- 2.40.0.1.gaa8946217a0b
| |