lkml.org 
[lkml]   [2023]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 30/50] spi: dt-bindings: atmel,at91rm9200-spi: remove 9x60 compatible from list
From
On 28/07/2023 12:28, Varshini Rajendran wrote:
> Remove microchip,sam9x60-spi compatible from the list as the fallback is
> really atmel,at91rm9200-spi.

Sorry, this explanation tells me nothing. The fallback is really
microchip,sam9x60-spi... You need to explain in commit msg why sam9x60
is incorrect as fallback.

>
> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
> ---
> Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
> index 58367587bfbc..32e7c14033c2 100644
> --- a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
> @@ -22,7 +22,6 @@ properties:
> - const: atmel,at91rm9200-spi
> - items:
> - const: microchip,sam9x7-spi
> - - const: microchip,sam9x60-spi

If that's true, then it should be part of previous enum.

> - const: atmel,at91rm9200-spi
>
> reg:

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-07-28 13:52    [W:0.024 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site