Messages in this thread | | | Date | Fri, 28 Jul 2023 12:35:39 +0200 | Subject | Re: [PATCH 5/8] mm/compaction: corret comment of cached migrate pfn update | From | David Hildenbrand <> |
| |
On 28.07.23 19:10, Kemeng Shi wrote: > Commit e380bebe47715 ("mm, compaction: keep migration source private to > a single compaction instance") moved update of async and sync > compact_cached_migrate_pfn from update_pageblock_skip to > update_cached_migrate but left the comment behind. > Move the relevant comment to correct this. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> > --- > mm/compaction.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 09c36251c613..1eebb61a1f63 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -464,6 +464,7 @@ static void update_cached_migrate(struct compact_control *cc, unsigned long pfn) > > pfn = pageblock_end_pfn(pfn); > > + /* Update where async and sync compaction should restart */ > if (pfn > zone->compact_cached_migrate_pfn[0]) > zone->compact_cached_migrate_pfn[0] = pfn; > if (cc->mode != MIGRATE_ASYNC && > @@ -485,7 +486,6 @@ static void update_pageblock_skip(struct compact_control *cc, > > set_pageblock_skip(page); > > - /* Update where async and sync compaction should restart */ > if (pfn < zone->compact_cached_free_pfn) > zone->compact_cached_free_pfn = pfn; > }
Again, no expert, but LGTM
Reviewed-by: David Hildenbrand <david@redhat.com>
-- Cheers,
David / dhildenb
| |