Messages in this thread | | | Date | Fri, 28 Jul 2023 12:33:10 +0200 | Subject | Re: [PATCH 8/8] mm/compaction: only set skip flag if cc->no_set_skip_hint is false | From | David Hildenbrand <> |
| |
On 28.07.23 19:10, Kemeng Shi wrote: > Keep the same logic as update_pageblock_skip, only set skip if > no_set_skip_hint is false which is more reasonable. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> > --- > mm/compaction.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 188d610eb3b6..6841c0496223 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1418,7 +1418,7 @@ fast_isolate_around(struct compact_control *cc, unsigned long pfn) > isolate_freepages_block(cc, &start_pfn, end_pfn, &cc->freepages, 1, false); > > /* Skip this pageblock in the future as it's full or nearly full */ > - if (start_pfn == end_pfn) > + if (start_pfn == end_pfn && !cc->no_set_skip_hint) > set_pageblock_skip(page); > } >
LGTM, although I am not an expert on that code.
Reviewed-by: David Hildenbrand <david@redhat.com>
-- Cheers,
David / dhildenb
| |