Messages in this thread | | | From | Ratheesh Kannoth <> | Subject | RE: Re: [PATCH v2 net-next] dissector: Use 64bits for used_keys | Date | Fri, 28 Jul 2023 10:09:29 +0000 |
| |
> -----Original Message----- > From: Petr Machata <petrm@nvidia.com> > Sent: Friday, July 28, 2023 3:00 PM > Subject: [EXT] Re: [PATCH v2 net-next] dissector: Use 64bits for used_keys > > > Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com> > > Reviewed-by: Petr Machata <petrm@nvidia.com> > > This makes it look like I reviewed the whole thing. I think I wrote > this: > > Reviewed-by: Petr Machata <petrm@nvidia.com> # for mlxsw I did not see any instances of adding like # "text". If it is valid style, I will fix it in next Patch.
> Also, you either missed or ignored my proposal for subject line update. > I do think that "net: flow_dissector:" would be a better prefix, because that's > how the component is called, and it's in the net namespace. It's OK not to > agree, but in that case please argue to that end.
My bad. I missed it. I will address in next patch.
| |