lkml.org 
[lkml]   [2023]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 net-next] dissector: Use 64bits for used_keys
Date

Ratheesh Kannoth <rkannoth@marvell.com> writes:

> As 32bit of dissector->used_keys are exhausted,
> increase the size to 64bits.
>
> This is base changes for ESP/AH flow dissector patch.
> Please find patch and discussions at
> https://lore.kernel.org/netdev/ZMDNjD46BvZ5zp5I@corigine.com/T/#t
>
> Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>
> Reviewed-by: Petr Machata <petrm@nvidia.com>

This makes it look like I reviewed the whole thing. I think I wrote
this:

Reviewed-by: Petr Machata <petrm@nvidia.com> # for mlxsw

Also, you either missed or ignored my proposal for subject line update.
I do think that "net: flow_dissector:" would be a better prefix, because
that's how the component is called, and it's in the net namespace. It's
OK not to agree, but in that case please argue to that end.

\
 
 \ /
  Last update: 2023-07-28 12:00    [W:0.052 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site