Messages in this thread | | | Date | Thu, 27 Jul 2023 16:00:08 +0300 | From | kirill.shutemov@linux ... | Subject | Re: [PATCH v3 03/12] x86/tdx: Make macros of TDCALLs consistent with the spec |
| |
On Wed, Jul 26, 2023 at 11:25:05PM +1200, Kai Huang wrote: > The TDX spec names all TDCALLs with prefix "TDG". Currently, the kernel > doesn't follow such convention for the macros of those TDCALLs but uses > prefix "TDX_" for all of them. Although it's arguable whether the TDX > spec names those TDCALLs properly, it's better for the kernel to follow > the spec when naming those macros. > > Change all macros of TDCALLs to make them consistent with the spec. As > a bonus, they get distinguished easily from the host-side SEAMCALLs, > which all have prefix "TDH". > > No functional change intended. > > Signed-off-by: Kai Huang <kai.huang@intel.com>
I remember we had few back-and-forth on naming this defines. I think matching names to the spec is helpful for future readers:
Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
-- Kiryl Shutsemau / Kirill A. Shutemov
| |