Messages in this thread | | | From | "Huang, Kai" <> | Subject | Re: [PATCH v3 03/12] x86/tdx: Make macros of TDCALLs consistent with the spec | Date | Fri, 28 Jul 2023 02:45:11 +0000 |
| |
On Thu, 2023-07-27 at 18:54 -0700, Sathyanarayanan Kuppuswamy wrote: > > On 7/26/23 4:25 AM, Kai Huang wrote: > > The TDX spec names all TDCALLs with prefix "TDG". Currently, the kernel > > doesn't follow such convention for the macros of those TDCALLs but uses > > prefix "TDX_" for all of them. Although it's arguable whether the TDX > > spec names those TDCALLs properly, it's better for the kernel to follow > > the spec when naming those macros. > > > > Change all macros of TDCALLs to make them consistent with the spec. As > > a bonus, they get distinguished easily from the host-side SEAMCALLs, > > which all have prefix "TDH". > > > > No functional change intended. > > > > When upstreaming the TDX guest patches, there was a discussion about using > TDG vs TDX. Final agreement is to use TDX_ prefix. I think it makes sense > to align with the spec, but it is up to the maintainer. > > What about the function name prefix? Are you planning to change them to tdg_*?
I changed to __tdcall() in the next patch.
> > Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Thanks.
| |