Messages in this thread | | | Date | Thu, 27 Jul 2023 13:09:19 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH] gpio: msc313: remove unnecessary call to platform_set_drvdata() |
| |
On Thu, Jul 27, 2023 at 09:00:36AM +0200, Romain Perier wrote:
First of all, please do not top-post!
> The private data is "struct msc313_gpio *gpio". This private data is > "binded" to the gpio_chip via devm_gpiochip_add_data, right ?
No.
> Then it is retrieved via gpiochip_get_data(chip), right ?
No.
The driver data is used in PM callbacks. See below.
> Le mar. 25 juil. 2023 à 15:22, Andy Shevchenko <andy@kernel.org> a écrit : > > > > On Fri, Jul 21, 2023 at 07:14:31PM +0300, Andy Shevchenko wrote: > > > On Fri, Jul 21, 2023 at 04:11:57PM +0300, Andrei Coardos wrote: > > > > This function call was found to be unnecessary as there is no equivalent > > > > platform_get_drvdata() call to access the private data of the driver. > > > > Not true.
^^^^
> > > > Also, the private data is defined in this driver, so there is no risk of > > > > it being accessed outside of this driver file. > > > > > > Reviewed-by: Andy Shevchenko <andy@kernel.org> > > > > I have to withdraw this, the patch is wrong. > > NAK. > > > > Sorry for the confusion (I have looked for the wrong pattern).
-- With Best Regards, Andy Shevchenko
| |