lkml.org 
[lkml]   [2023]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] gpio: msc313: remove unnecessary call to platform_set_drvdata()
On Fri, Jul 21, 2023 at 07:14:31PM +0300, Andy Shevchenko wrote:
> On Fri, Jul 21, 2023 at 04:11:57PM +0300, Andrei Coardos wrote:
> > This function call was found to be unnecessary as there is no equivalent
> > platform_get_drvdata() call to access the private data of the driver.

Not true.

> > Also, the private data is defined in this driver, so there is no risk of
> > it being accessed outside of this driver file.
>
> Reviewed-by: Andy Shevchenko <andy@kernel.org>

I have to withdraw this, the patch is wrong.
NAK.

Sorry for the confusion (I have looked for the wrong pattern).

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2023-07-25 15:20    [W:0.073 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site