Messages in this thread | | | From | Wedson Almeida Filho <> | Date | Thu, 27 Jul 2023 05:06:32 -0300 | Subject | Re: [RFC PATCH v2 10/10] rust: puzzlefs: add oci_root_dir and image_manifest filesystem parameters |
| |
On Wed, 26 Jul 2023 at 21:02, Trevor Gross <tmgross@umich.edu> wrote: > > On Wed, Jul 26, 2023 at 7:48 PM Wedson Almeida Filho <wedsonaf@gmail.com> wrote: > > > > On Wed, 26 Jul 2023 at 18:08, Trevor Gross <tmgross@umich.edu> wrote: > > > > > [...] > > > The guard syntax (available since 1.65) can make these kinds of match statements > > > cleaner: > > > > This is unstable though. > > > > We try to stay away from unstable features unless we really need them, > > which I feel is not the case here. > > > > Let/else has been stable since 1.65 and is in pretty heavy use, the > kernel is on 1.68.2 correct? Could you be thinking of let chains > (multiple matches joined with `&&`/`||`)?
Oh, my bad. I got it mixed with "if let guard" (issue 51114).
And yeah, we're on 1.68.2, so this code can benefit from this simplification.
Thanks!
> > > let Some(oci_root_dir) = data.oci_root_dir else { > > pr_err!("missing oci_root_dir parameter!\n"); > > return Err(ENOTSUPP); > > } > > [...]
| |