Messages in this thread | | | From | Trevor Gross <> | Date | Wed, 26 Jul 2023 20:02:10 -0400 | Subject | Re: [RFC PATCH v2 10/10] rust: puzzlefs: add oci_root_dir and image_manifest filesystem parameters |
| |
On Wed, Jul 26, 2023 at 7:48 PM Wedson Almeida Filho <wedsonaf@gmail.com> wrote: > > On Wed, 26 Jul 2023 at 18:08, Trevor Gross <tmgross@umich.edu> wrote: > > > [...] > > The guard syntax (available since 1.65) can make these kinds of match statements > > cleaner: > > This is unstable though. > > We try to stay away from unstable features unless we really need them, > which I feel is not the case here. >
Let/else has been stable since 1.65 and is in pretty heavy use, the kernel is on 1.68.2 correct? Could you be thinking of let chains (multiple matches joined with `&&`/`||`)?
> let Some(oci_root_dir) = data.oci_root_dir else { > pr_err!("missing oci_root_dir parameter!\n"); > return Err(ENOTSUPP); > } > [...]
| |