Messages in this thread | | | From | like@awinic ... | Subject | Re: [PATCH V1 1/2] regulator: aw37503: add regulator driver for AWINIC AW37503 | Date | Fri, 28 Jul 2023 03:20:04 +0000 |
| |
Hello Mark Brown, Thank you very much for your advice.
> On Wed, Jul 26, 2023 at 08:16:11AM +0000, like@awinic.com wrote: > > > @@ -191,5 +191,6 @@ obj-$(CONFIG_REGULATOR_WM831X) += wm831x-ldo.o > > obj-$(CONFIG_REGULATOR_WM8350) += wm8350-regulator.o > > obj-$(CONFIG_REGULATOR_WM8400) += wm8400-regulator.o > > obj-$(CONFIG_REGULATOR_WM8994) += wm8994-regulator.o > > +obj-$(CONFIG_REGULATOR_AW37503) += aw37503-regulator.o > > > > Please keep the Kconfig and Makefile sorted.
I will modify the sorting of AW37503 as suggested.
> > +static const struct regmap_config aw37503_regmap_config = { > > + .reg_bits = 8, > > + .val_bits = 8, > > + .max_register = AW37503_REG_WPRTEN, > > + .cache_type = REGCACHE_NONE, > > No need to specify no cache, it's the default.
I will modify it as suggested.
Best regards, Alec Li
| |