Messages in this thread | | | Date | Wed, 26 Jul 2023 22:13:55 +0200 | Subject | Re: [PATCH V1 1/2] regulator: aw37503: add regulator driver for AWINIC AW37503 | From | Christophe JAILLET <> |
| |
Le 26/07/2023 à 10:16, like-tUEr1MkLeujQT0dZR+AlfA@public.gmane.org a écrit : > From: Alec Li <like-tUEr1MkLeujQT0dZR+AlfA@public.gmane.org> > > Add regulator driver for the device AWINIC AW37503 which is single > inductor - dual output power supply device. AW37503 device is > designed to support general positive/negative driven applications > like TFT display panels. > > AW37503 regulator driver supports to enable/disable and set voltage > on its output. > > Signed-off-by: Alec Li <like-tUEr1MkLeujQT0dZR+AlfA@public.gmane.org>
[...]
> +static int aw37503_probe(struct i2c_client *client) > +{ > + struct device *dev = &client->dev; > + struct aw37503_regulator *chip; > + struct regulator_dev *rdev; > + struct regmap *regmap; > + struct regulator_config config = { }; > + int id; > + int ret; > + > + chip = devm_kzalloc(dev, sizeof(*chip), GFP_KERNEL); > + if (!chip) > + return -ENOMEM; > + > + regmap = devm_regmap_init_i2c(client, &aw37503_regmap_config); > + if (IS_ERR(regmap)) { > + ret = PTR_ERR(regmap); > + dev_err(dev, "regmap init failed: %d\n", ret); > + return ret; > + } > + > + i2c_set_clientdata(client, chip); > + chip->dev = dev; > + > + for (id = 0; id < AW37503_MAX_REGULATORS; ++id) { > + config.regmap = regmap; > + config.dev = dev; > + config.driver_data = chip;
I think that these 3 lines could be outside of the loop.
> + > + rdev = devm_regulator_register(dev, &aw_regs_desc[id], > + &config); > + if (IS_ERR(rdev)) { > + ret = PTR_ERR(rdev); > + dev_err(dev, "regulator %s register failed: %d\n", > + aw_regs_desc[id].name, ret); > + return ret; > + } > + } > + return 0; > +}
[...]
| |