Messages in this thread Patch in this message | | | From | Baoquan He <> | Subject | [PATCH v2] mm/percpu.c: print error message too if atomic alloc failed | Date | Fri, 28 Jul 2023 11:02:55 +0800 |
| |
The variable 'err' is assgigned to an error message if atomic alloc failed, while it has no chance to be printed if is_atomic is true.
Here change to print error message too if atomic alloc failed, while avoid to call dump_stack() if that case.
Signed-off-by: Baoquan He <bhe@redhat.com> --- v1->v2: Fix the code bug in v1 pointed out by Dennis.
mm/percpu.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/mm/percpu.c b/mm/percpu.c index 83fc47206680..bdca8ec33d49 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -1890,13 +1890,15 @@ static void __percpu *pcpu_alloc(size_t size, size_t align, bool reserved, fail: trace_percpu_alloc_percpu_fail(reserved, is_atomic, size, align); - if (!is_atomic && do_warn && warn_limit) { + if (do_warn && warn_limit) { pr_warn("allocation failed, size=%zu align=%zu atomic=%d, %s\n", size, align, is_atomic, err); - dump_stack(); + if (!is_atomic) + dump_stack(); if (!--warn_limit) pr_info("limit reached, disable warning\n"); } + if (is_atomic) { /* see the flag handling in pcpu_balance_workfn() */ pcpu_atomic_alloc_failed = true; -- 2.34.1
| |