Messages in this thread | | | Date | Thu, 27 Jul 2023 15:43:31 -0300 | From | Jason Gunthorpe <> | Subject | Re: [PATCH v1 7/7] iommu/arm-smmu-v3: Move CD table to arm_smmu_master |
| |
On Fri, Jul 28, 2023 at 02:26:23AM +0800, Michael Shavit wrote: > Each master is now allocated a CD table at probe time,
Currently it is allocated during arm_smmu_domain_finalise_s1(), so it isn't allocated at probe time.
I think the right place to put the allocation is during the attach op, the first time we need a CD table then go and allocate it. If we can't then domain attach fails with -ENOMEM.
Then you can put the free in a detach op once the CD table becomes empty and it behaves much like it already does.
Jason
| |