Messages in this thread | | | From | Michael Shavit <> | Date | Fri, 28 Jul 2023 15:47:45 +0800 | Subject | Re: [PATCH v1 2/7] iommu/arm-smmu-v3: Replace s1_cfg with ctx_desc_cfg |
| |
On Fri, Jul 28, 2023 at 4:57 AM Nicolin Chen <nicolinc@nvidia.com> wrote:
> It'd be nicer to align all the variables to "cd_table" like the > 2nd piece here. And if we rename the struct name too: > > struct arm_smmu_cdtab_cfg *cd_table = xxxx;
I agree that renaming these would be nice. There's 36 usages of cdcfg in arm-smmu-v3.c, and 6 usages of arm_smmu_ctx_desc_cfg. I can rename the struct since we'll be touching many of those in this patch anyways, but I'm a bit concerned of the churn from updating all the cdcfg usages.
> Though "s1fmt" is redundant, "max_cds_bits" doesn't seem to be. > > It'd be nicer to separate them in the commit message to why we > remove s1fmt and why we rename s1cdmax.
Will fix!
| |