Messages in this thread | | | From | Raul Rangel <> | Date | Thu, 27 Jul 2023 12:30:30 -0600 | Subject | Re: [PATCH] platform/chrome: cros_ec_lpc: Add DMI definition for post-Skylake machines running custom Coreboot builds |
| |
On Thu, Jul 20, 2023 at 4:37 PM Alicja Michalska <ahplka19@gmail.com> wrote: > > ChromeOS EC LPC lacks DMI match for newer machines, which > use "Google" DMI_SYS_VENDOR as opposed to "GOOGLE" in older models. > This patch adds DMI definition for MrChomebox's custom Coreboots builds, > which we (Chrultrabook Project) are using. > > Signed-off-by: Alicja Michalska <ahplka19@gmail.com> > --- > drivers/platform/chrome/cros_ec_lpc.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c > index 500a61b093e4..6ac993be4eb1 100644 > --- a/drivers/platform/chrome/cros_ec_lpc.c > +++ b/drivers/platform/chrome/cros_ec_lpc.c > @@ -533,6 +533,14 @@ static const struct dmi_system_id cros_ec_lpc_dmi_table[] __initconst = { > DMI_MATCH(DMI_PRODUCT_NAME, "Glimmer"), > }, > }, > + /* DMI doesn't match modern machines running custom firmware */ > + { > + /* MrChromebox's firmware */ > + .matches = { > + DMI_MATCH(DMI_BIOS_VENDOR, "coreboot"), > + DMI_MATCH(DMI_BIOS_VERSION, "MrChromebox-"), > + }, > + }, > /* A small number of non-Chromebook/box machines also use the ChromeOS EC */ > { > /* the Framework Laptop */ > -- > 2.41.0
+ Mrchromebox
Hrmm, it looks like this table is only used if the GOOG0004 ACPI device wasn't found. Is the MrChromebox fw missing this ACPI device?
| |