Messages in this thread | | | Date | Fri, 21 Jul 2023 14:39:05 +0800 | From | Tzung-Bi Shih <> | Subject | Re: [PATCH] platform/chrome: cros_ec_lpc: Add DMI definition for post-Skylake machines running custom Coreboot builds |
| |
On Fri, Jul 21, 2023 at 12:37:15AM +0200, Alicja Michalska wrote: > ChromeOS EC LPC lacks DMI match for newer machines, which > use "Google" DMI_SYS_VENDOR as opposed to "GOOGLE" in older models.
I'm confused about the sentence as it looks irrelevant to the patch.
> This patch adds DMI definition for MrChomebox's custom Coreboots builds, > which we (Chrultrabook Project) are using.
s/This patch adds/Add/. Search "imperative mood" in [1].
Looks like a typo: s/MrChomebox/MrChromebox/.
If you get chance to send next version, please shorten the commit title. I guess "platform/chrome: cros_ec_lpc: Add DMI match for MrChromebox" should be quite explicit.
[1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> + /* DMI doesn't match modern machines running custom firmware */
Remove the line.
> + { > + /* MrChromebox's firmware */ > + .matches = { > + DMI_MATCH(DMI_BIOS_VENDOR, "coreboot"), > + DMI_MATCH(DMI_BIOS_VERSION, "MrChromebox-"), > + }, > + },
Put the block after "A small number of non-Chromebook/box machines also use the ChromeOS EC"[2].
[2]: https://elixir.bootlin.com/linux/v6.4/source/drivers/platform/chrome/cros_ec_lpc.c#L533
| |