Messages in this thread | | | Date | Thu, 27 Jul 2023 08:50:49 -0700 | From | Luis Chamberlain <> | Subject | Re: [PATCH 09/14] ax.25: Update to register_net_sysctl_sz |
| |
On Thu, Jul 27, 2023 at 05:38:04PM +0200, Joel Granados wrote: > On Wed, Jul 26, 2023 at 11:00:37AM -0700, Luis Chamberlain wrote: > > On Wed, Jul 26, 2023 at 04:06:29PM +0200, Joel Granados wrote: > > > This is part of the effort to remove the sentinel (last empty) element > > > from the ctl_table arrays. We update to the new function and pass it the > > > array size. > > > > The commit log does not explain why. It also does not explain if there > > is any delta on size at compile or runtime. > Just to be on the same page: > You mean the specific why for this commit. like for example: > " > We update to register_net_sysctl_sz
I think it is clearer to just say:
Move from register_net_sysctl() to register_net_sysctl_sz()
> to prepare for when the ctl_table > array sentinels are removed.
That is not as clear. I think you should just spell it out.
We want to use the syctl ARRAY_SIZE() when possible, and subsequent patches ... now the register_net_sysctl() <does something> while register_net_sysctl_sz() <does something else> and <in this case> this user <does something> and so we must use register_net_sysctl_sz().
> " > > right?
Luis
| |