Messages in this thread | | | Date | Fri, 28 Jul 2023 09:35:36 +0200 | From | Joel Granados <> | Subject | Re: [PATCH 09/14] ax.25: Update to register_net_sysctl_sz |
| |
On Thu, Jul 27, 2023 at 08:44:24AM -0700, Luis Chamberlain wrote: > On Thu, Jul 27, 2023 at 02:31:12PM +0200, Joel Granados wrote: > > There are no deltas in this patch set. We start seeing the deltas when > > we start removing with the next 6 chunks. I'll try to make that more > > clear in the commit message. > > Indeed, even if no deltas are created it is importan then to say that. > If there are no deltas the "why" becomes more important. If the why is > to make it easier to apply subsequent patches, that must be said. When yes. The why for this patch set in particular is to make it easier to apply the sentinel removal patches.
I think the difficulty for me comes from having two whys: 1. The one for this patch set which is to make it easier to apply sentinel removal patches. And 2. The one for the "big" patch (that actually removes the sentinels) which is to reduce build time size and run time memory bloat.
> you iterate your new series try to review the patches as if you were not > the person submitting them, and try to think of ways to make it easier > for the patch reviewer to do less work. The less work and easier patch > review is the better for them. Ack. For all these commits I'll try to weave in the two Whys to make the review process a bit easier.
> > Luis
--
Joel Granados [unhandled content-type:application/pgp-signature] | |