lkml.org 
[lkml]   [2023]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5] i2c: imx-lpi2c: return -EINVAL when i2c peripheral clk doesn't work
Hi Carlos,

On Wed, Jul 26, 2023 at 05:22:38PM +0800, carlos.song@nxp.com wrote:
> From: Carlos Song <carlos.song@nxp.com>
>
> On MX8X platforms, the default clock rate is 0 if without explicit
> clock setting in dts nodes. I2c can't work when i2c peripheral clk
> rate is 0.
>
> Add a i2c peripheral clk rate check before configuring the clock
> register. When i2c peripheral clk rate is 0 and directly return
> -EINVAL.
>
> Signed-off-by: Carlos Song <carlos.song@nxp.com>

you are missing here:

Acked-by: Dong Aisheng <Aisheng.dong@nxp.com>

You can also add:

Reviewed-by: Andi Shyti <andi.shyti@kernel.org>

(no need to resend)

Thanks!
Andi

\
 
 \ /
  Last update: 2023-07-26 16:59    [W:0.101 / U:0.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site