Messages in this thread | | | Date | Wed, 26 Jul 2023 11:53:11 +0200 | Subject | Re: [PATCH v5 1/2] regulator: dt-bindings: rtq2208: Add Richtek RTQ2208 SubPMIC | From | Krzysztof Kozlowski <> |
| |
On 26/07/2023 09:13, Alina Yu wrote: > Add bindings for Richtek RTQ2208 IC controlled SubPMIC > > Signed-off-by: Alina Yu <alina_yu@richtek.com>
Thank you for your patch. There is something to discuss/improve.
> + > + richtek,mtp-sel-high: > + type: boolean > + description: > + vout register selection based on this boolean value. > + false - Using DVS0 register setting to adjust vout > + true - Using DVS1 register setting to adjust vout > + > + regulators: > + type: object > +
On this level of indentation:
additionalProperties: false
I think I missed this in previous versions. I am sorry.
Rest looks good to me, but this needs to be fixed.
Best regards, Krzysztof
| |