Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Andrei Coardos <> | Subject | [PATCH v2] gpio: max77620: remove unneeded platform_set_drvdata() call | Date | Tue, 25 Jul 2023 15:36:23 +0300 |
| |
This function call is not required because no counterpart platform_get_drvdata() call is present to leverage the private data of the driver. Since the private data is confined to this driver file, external access is not feasible. The use of this function appears redundant in the current context of the driver's implementation.
Reviewed-by: Alexandru Ardelean <alex@shruggie.ro> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com> ---
Changelog V1->V2:
* https://lore.kernel.org/linux-gpio/20230720132535.23413-1-aboutphysycs@gmail.com/ * fixed subject line: adjusted colons where needed
drivers/gpio/gpio-max77620.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-max77620.c b/drivers/gpio/gpio-max77620.c index c18b60e39a94..8c2a5609161f 100644 --- a/drivers/gpio/gpio-max77620.c +++ b/drivers/gpio/gpio-max77620.c @@ -331,8 +331,6 @@ static int max77620_gpio_probe(struct platform_device *pdev) girq->init_hw = max77620_gpio_irq_init_hw; girq->threaded = true; - platform_set_drvdata(pdev, mgpio); - ret = devm_gpiochip_add_data(&pdev->dev, &mgpio->gpio_chip, mgpio); if (ret < 0) { dev_err(&pdev->dev, "gpio_init: Failed to add max77620_gpio\n"); -- 2.34.1
| ![\](/images/icornerr.gif) |