Messages in this thread | | | Date | Sat, 15 Jul 2023 10:00:34 +0000 | From | Benno Lossin <> | Subject | Re: [PATCH] rust: kernel: str: Implement Debug for CString |
| |
On 14.07.23 11:19, Asahi Lina wrote: > Trivial implementation. > > Signed-off-by: Asahi Lina <lina@asahilina.net>
With a better commit message you can add
Reviewed-by: Benno Lossin <benno.lossin@proton.me>
-- Cheers, Benno
> --- > rust/kernel/str.rs | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/rust/kernel/str.rs b/rust/kernel/str.rs > index c9dd3bf59e34..a94e396d39e1 100644 > --- a/rust/kernel/str.rs > +++ b/rust/kernel/str.rs > @@ -606,6 +606,12 @@ fn try_from(cstr: &'a CStr) -> Result<CString, AllocError> { > } > } > > +impl fmt::Debug for CString { > + fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { > + fmt::Debug::fmt(&**self, f) > + } > +} > + > /// A convenience alias for [`core::format_args`]. > #[macro_export] > macro_rules! fmt { > > --- > base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5 > change-id: 20230714-cstring-debug-ca021fe0ad78 > > Thank you, > ~~ Lina >
| |