Messages in this thread | | | Date | Fri, 14 Jul 2023 10:46:56 -0300 | Subject | Re: [PATCH] rust: kernel: str: Implement Debug for CString | From | Martin Rodriguez Reboredo <> |
| |
On 7/14/23 09:21, Asahi Lina wrote: > On 14/07/2023 18.48, Alice Ryhl wrote: >> Asahi Lina <lina@asahilina.net> writes: >>> Trivial implementation. >>> >>> Signed-off-by: Asahi Lina <lina@asahilina.net> >> >> The commit message is a bit short, but the change itself looks fine. >> >> Reviewed-by: Alice Ryhl <aliceryhl@google.com> > > It's so trivial I just didn't know what else to write... suggestions > welcome (for this or next time I have a patch like this) ^^ > > ~~ Lina >
Just describe what it does, like "cast the `CStr` to an `&str` and call `fmt::Debug::fmt` with it". I'll add my Reviewed-by, so retain it in case it's asked to change the commit message.
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
| |