Messages in this thread | | | Date | Fri, 14 Jul 2023 12:41:02 +0100 | From | "Russell King (Oracle)" <> | Subject | Re: [PATCH v2 5/6] net: phy: at803x: remove qca8081 1G fast retrain and slave seed config |
| |
On Fri, Jul 14, 2023 at 02:31:35PM +0800, Luo Jie wrote: > The fast retrain and master slave seed configs are only applicable when > the 2.5G capability is supported.
Probably worth a comment - or a helper function.
E.g.
static bool qca808x_has_fast_retrain(struct phy_device *phydev) { return linkmode_test_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT, phydev->supported); }
Which then makes the code more self-documenting.
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
| |