Messages in this thread | | | From | Javier Martinez Canillas <> | Subject | Re: [PATCH 5/8] drm/client: Convert drm_mode_create_dumb() to drm_mode_addfb2() | Date | Fri, 14 Jul 2023 12:16:19 +0200 |
| |
Geert Uytterhoeven <geert@linux-m68k.org> writes:
> Currently drm_client_buffer_addfb() uses the legacy drm_mode_addfb(), > which uses bpp and depth to guess the wanted buffer format. > However, drm_client_buffer_addfb() already knows the exact buffer > format, so there is no need to convert back and forth between buffer > format and bpp/depth, and the function can just call drm_mode_addfb2() > directly instead. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > drivers/gpu/drm/drm_client.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) >
Nice cleanup!
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
-- Best regards,
Javier Martinez Canillas Core Platforms Red Hat
| |