Messages in this thread | | | Date | Fri, 14 Jul 2023 12:12:54 +0200 | Subject | Re: [PATCH 58/58] mmc: Convert to platform remove callback returning void | From | Florian Fainelli <> |
| |
On 7/13/2023 10:08 AM, Yangtao Li wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Signed-off-by: Yangtao Li <frank.li@vivo.com> > --- > drivers/mmc/host/sdhci-bcm-kona.c | 2 +- > drivers/mmc/host/sdhci-brcmstb.c | 2 +-
Acked-by: Florian Fainelli <florian.fainelli@broadcom.com> # Broadcom drivers -- Florian [unhandled content-type:application/pkcs7-signature]
| |