Messages in this thread | | | Date | Fri, 14 Jul 2023 11:55:28 +0200 | Subject | Re: [PATCH v1 0/4] virtio-mem: memory unplug/offlining related cleanups | From | David Hildenbrand <> |
| |
On 13.07.23 17:03, Michael S. Tsirkin wrote: > On Thu, Jul 13, 2023 at 04:55:47PM +0200, David Hildenbrand wrote: >> Some cleanups+optimizations primarily around offline_and_remove_memory(). >> >> Patch #1 drops the "unsafe unplug" feature where we might get stuck in >> offline_and_remove_memory() forever. >> >> Patch #2 handles unexpected errors from offline_and_remove_memory() a bit >> nicer. >> >> Patch #3 handles the case where offline_and_remove_memory() failed and >> we want to retry later to remove a completely unplugged Linux memory >> block, to not have them waste memory forever. >> >> Patch #4 something I had lying around for longer, which reacts faster >> on config changes when unplugging memory. >> >> Cc: "Michael S. Tsirkin" <mst@redhat.com> >> Cc: Jason Wang <jasowang@redhat.com> >> Cc: Xuan Zhuo <xuanzhuo@linux.alibaba.com> > > This looks like something that's reasonable to put in this linux, right? > These are fixes even though they are for theoretical issues.
Yes, but these are not high-priority fixes+optimizations. So if you feel like we should be delaying them, fine with me.
On the other hand, getting them in now also shouldn't really hurt. Especially patch #1 might be better of just going in soner than later.
-- Cheers,
David / dhildenb
| |