Messages in this thread Patch in this message | | | From | Minjie Du <> | Subject | [PATCH v4] iommu: remove redundant parameter check in tegra_smmu_debugfs_init() | Date | Fri, 14 Jul 2023 17:02:44 +0800 |
| |
debugfs_create_file() will return early if smmu->debugfs is an error pointer, so an extra error check is not needed.
Signed-off-by: Minjie Du <duminjie@vivo.com> Acked-by: Thierry Reding <treding@nvidia.com> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com> --- V4 -> V6: Add 'Reviewed-by' tag on the basis of V4. V5: error patch, should be discarded. V3 -> V4: fix expression about patch. V2 -> V3: fix expression about patch. V1 -> V2: remove the error check. V1: use IS_ERR() to error check. --- drivers/iommu/tegra-smmu.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c index 1cbf063cc..2137040b7 100644 --- a/drivers/iommu/tegra-smmu.c +++ b/drivers/iommu/tegra-smmu.c @@ -1056,8 +1056,6 @@ DEFINE_SHOW_ATTRIBUTE(tegra_smmu_clients); static void tegra_smmu_debugfs_init(struct tegra_smmu *smmu) { smmu->debugfs = debugfs_create_dir("smmu", NULL); - if (!smmu->debugfs) - return; debugfs_create_file("swgroups", S_IRUGO, smmu->debugfs, smmu, &tegra_smmu_swgroups_fops); -- 2.39.0
| |