Messages in this thread | | | Date | Fri, 14 Jul 2023 10:00:59 +0200 | From | Horatiu Vultur <> | Subject | Re: [PATCH v7 net-next 00/10] Introduce ndo_hwtstamp_get() and ndo_hwtstamp_set() |
| |
The 07/13/2023 15:18, Vladimir Oltean wrote:
Hi Vladimir,
> > Based on previous RFCs from Maxim Georgiev: > https://lore.kernel.org/netdev/20230502043150.17097-1-glipus@gmail.com/ > > this series attempts to introduce new API for the hardware timestamping > control path (SIOCGHWTSTAMP and SIOCSHWTSTAMP handling). > > I don't have any board with phylib hardware timestamping, so I would > appreciate testing (especially on lan966x, the most intricate > conversion). I was, however, able to test netdev level timestamping, > because I also have some more unsubmitted conversions in progress: > > https://github.com/vladimiroltean/linux/commits/ndo-hwtstamp-v7
I have tested this patch series on lan966x. In both cases, when there is a PHY that supports HW timestamping and when the isn't a PHY that supports HW timestamping. In both cases it behaves as expected. Thanks! Tested-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > I hope that the concerns expressed in the comments of previous series > were addressed, and that Köry Maincent's series: > https://lore.kernel.org/netdev/20230406173308.401924-1-kory.maincent@bootlin.com/ > can make progress in parallel with the conversion of the rest of drivers. > > Maxim Georgiev (5): > net: add NDOs for configuring hardware timestamping > net: add hwtstamping helpers for stackable net devices > net: vlan: convert to ndo_hwtstamp_get() / ndo_hwtstamp_set() > net: macvlan: convert to ndo_hwtstamp_get() / ndo_hwtstamp_set() > net: bonding: convert to ndo_hwtstamp_get() / ndo_hwtstamp_set() > > Vladimir Oltean (5): > net: fec: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set() > net: fec: delete fec_ptp_disable_hwts() > net: sparx5: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set() > net: lan966x: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set() > net: remove phy_has_hwtstamp() -> phy_mii_ioctl() decision from > converted drivers > > drivers/net/bonding/bond_main.c | 105 ++++++---- > drivers/net/ethernet/freescale/fec.h | 6 +- > drivers/net/ethernet/freescale/fec_main.c | 41 ++-- > drivers/net/ethernet/freescale/fec_ptp.c | 43 ++-- > .../ethernet/microchip/lan966x/lan966x_main.c | 61 ++++-- > .../ethernet/microchip/lan966x/lan966x_main.h | 12 +- > .../ethernet/microchip/lan966x/lan966x_ptp.c | 34 ++-- > .../ethernet/microchip/sparx5/sparx5_main.h | 9 +- > .../ethernet/microchip/sparx5/sparx5_netdev.c | 35 +++- > .../ethernet/microchip/sparx5/sparx5_ptp.c | 24 ++- > drivers/net/macvlan.c | 34 ++-- > include/linux/net_tstamp.h | 28 +++ > include/linux/netdevice.h | 25 +++ > net/8021q/vlan_dev.c | 27 ++- > net/core/dev_ioctl.c | 183 +++++++++++++++++- > 15 files changed, 480 insertions(+), 187 deletions(-) > > -- > 2.34.1 >
-- /Horatiu
| |