Messages in this thread Patch in this message | | | From | Tom Rix <> | Subject | [PATCH] shmem: set variable shmem_mark_dquot_dirty and shmem_dquot_write_info storage-class-specifier to static | Date | Fri, 14 Jul 2023 17:51:13 -0400 |
| |
smatch reports mm/shmem_quota.c:318:5: warning: symbol 'shmem_mark_dquot_dirty' was not declared. Should it be static? mm/shmem_quota.c:323:5: warning: symbol 'shmem_dquot_write_info' was not declared. Should it be static?
These variables are only used in their defining file, so it should be static.
Signed-off-by: Tom Rix <trix@redhat.com> --- mm/shmem_quota.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/shmem_quota.c b/mm/shmem_quota.c index e349c0901bce..062d1c1097ae 100644 --- a/mm/shmem_quota.c +++ b/mm/shmem_quota.c @@ -315,12 +315,12 @@ static int shmem_release_dquot(struct dquot *dquot) return 0; } -int shmem_mark_dquot_dirty(struct dquot *dquot) +static int shmem_mark_dquot_dirty(struct dquot *dquot) { return 0; } -int shmem_dquot_write_info(struct super_block *sb, int type) +static int shmem_dquot_write_info(struct super_block *sb, int type) { return 0; } -- 2.27.0
| |