Messages in this thread | | | Date | Thu, 13 Jul 2023 23:35:40 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH] xfs:Comparisons should place the constant on the right side of the test The if statement uses an assignment statement as a condition, which is confusing. |
| |
On Fri, Jul 14, 2023 at 02:26:08PM +0800, liubin001@208suo.com wrote: > xfs:The if statement uses an assignment statement as a condition, which is > confusing. > Signed-off-by: Liu Bin <liubin001@208suo.com>
What's the point? I prefer the style you change it to as well, but there is no real downside, and changing code just for the sake of it causes nothing but churn.
| |