Messages in this thread | | | From | Jason Wang <> | Date | Fri, 14 Jul 2023 11:58:46 +0800 | Subject | Re: [PATCH v2 net] gso: fix dodgy bit handling for GSO_UDP_L4 |
| |
On Fri, Jul 14, 2023 at 1:28 AM Yan Zhai <yan@cloudflare.com> wrote: > > Commit 1fd54773c267 ("udp: allow header check for dodgy GSO_UDP_L4 > packets.") checks DODGY bit for UDP, but for packets that can be fed > directly to the device after gso_segs reset, it actually falls through > to fragmentation: > > https://lore.kernel.org/all/CAJPywTKDdjtwkLVUW6LRA2FU912qcDmQOQGt2WaDo28KzYDg+A@mail.gmail.com/ > > This change restores the expected behavior of GSO_UDP_L4 packets. > > Fixes: 1fd54773c267 ("udp: allow header check for dodgy GSO_UDP_L4 packets.") > Suggested-by: Willem de Bruijn <willemdebruijn.kernel@gmail.com> > Signed-off-by: Yan Zhai <yan@cloudflare.com> > > --- > v2: dropped modifications to tcp/sctp on DODGY bit removal after > validating gso_segs. Also moved the UDP header check into > __udp_gso_segment (per Willem's suggestion). >
Acked-by: Jason Wang <jasowang@redhat.com>
Thanks
| |