Messages in this thread | | | Date | Fri, 14 Jul 2023 01:33:53 +0300 | From | Vladimir Oltean <> | Subject | Re: [PATCH v7 net-next 00/10] Introduce ndo_hwtstamp_get() and ndo_hwtstamp_set() |
| |
On Thu, Jul 13, 2023 at 02:50:39PM -0700, Jacob Keller wrote: > On 7/13/2023 5:18 AM, Vladimir Oltean wrote: > > Based on previous RFCs from Maxim Georgiev: > > https://lore.kernel.org/netdev/20230502043150.17097-1-glipus@gmail.com/ > > > > this series attempts to introduce new API for the hardware timestamping > > control path (SIOCGHWTSTAMP and SIOCSHWTSTAMP handling). > > > > I don't have any board with phylib hardware timestamping, so I would > > appreciate testing (especially on lan966x, the most intricate > > conversion). I was, however, able to test netdev level timestamping, > > because I also have some more unsubmitted conversions in progress: > > > > https://github.com/vladimiroltean/linux/commits/ndo-hwtstamp-v7 > > > > I hope that the concerns expressed in the comments of previous series > > were addressed, and that Köry Maincent's series: > > https://lore.kernel.org/netdev/20230406173308.401924-1-kory.maincent@bootlin.com/ > > can make progress in parallel with the conversion of the rest of drivers. > > > > This series looks good to me, nice cleanup and reducing some boiler > plate code is excellent. > > I'd like to convert the Intel drivers too, but I am not sure when I can > commit to doing that as I have a lot on my plate presently. > > Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Thanks for the review. The conversion of Intel drivers is in the Github link I had posted.
| |