lkml.org 
[lkml]   [2023]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/2] regulator: dt-bindings: rtq2208: Add Richtek RTQ2208 SubPMIC
On Mon, Jul 10, 2023 at 08:02:39AM +0200, Krzysztof Kozlowski wrote:
> On 10/07/2023 05:08, Alina Yu wrote:
> >> Yes, "0" refers to DVS0 registers, and "1" refers to DVS1.
> >> and there is only DVS0 and DVS1, so I use boolean to check which one is used.
> >>
> >> Is it more understandable if I modify that to enum ? And description will be like this
> >>
> >> richtek,mtp-sel:
> >> enum: [0, 1]
> >> description: |
> >> vout register selection besed on this value.
> >> 0 - Using DVS0 register setting to adjust vout
> >> 1 - Using DVS1 register setting to adjust vout
> >>
> >
> > May I ask one more question ?
> > If I modify the name into "richtek,mtp-sel-high", is that more understandable ?
> > It will be like this,
> >
> > richtek,mtp-sel-high:
> > type: boolean
> > description:
> > vout register selection besed on this value.
> > 0 - Using DVS0 register setting to adjust vout
> > 1 - Using DVS1 register setting to adjust vout
>
> You don't have 0 or 1 values in such case. The property can be bool, but
> description is not good.
>

May I modify the description like this ?

richtek,mtp-sel-high:
type: boolean
description:
vout register selection besed on this boolean value.
false - Using DVS0 register setting to adjust vout
true - Using DVS1 register setting to adjust vout


BR,
Alina.

\
 
 \ /
  Last update: 2023-07-10 09:24    [W:0.039 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site