lkml.org 
[lkml]   [2023]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 1/2] regulator: dt-bindings: rtq2208: Add Richtek RTQ2208 SubPMIC
From
On 10/07/2023 05:08, Alina Yu wrote:
>> Yes, "0" refers to DVS0 registers, and "1" refers to DVS1.
>> and there is only DVS0 and DVS1, so I use boolean to check which one is used.
>>
>> Is it more understandable if I modify that to enum ? And description will be like this
>>
>> richtek,mtp-sel:
>> enum: [0, 1]
>> description: |
>> vout register selection besed on this value.
>> 0 - Using DVS0 register setting to adjust vout
>> 1 - Using DVS1 register setting to adjust vout
>>
>
> May I ask one more question ?
> If I modify the name into "richtek,mtp-sel-high", is that more understandable ?
> It will be like this,
>
> richtek,mtp-sel-high:
> type: boolean
> description:
> vout register selection besed on this value.
> 0 - Using DVS0 register setting to adjust vout
> 1 - Using DVS1 register setting to adjust vout

You don't have 0 or 1 values in such case. The property can be bool, but
description is not good.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-07-10 08:03    [W:0.748 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site