Messages in this thread Patch in this message | | | Date | Mon, 10 Jul 2023 14:37:01 +0800 | From | sunran001@208suo ... | Subject | [PATCH] drm/nouveau/i2c: do not use assignment in if condition |
| |
Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning:
ERROR: do not use assignment in if condition
Signed-off-by: Ran Sun <sunran001@208suo.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busgf119.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busgf119.c b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busgf119.c index 96bbdda0f439..a1cf406ff141 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busgf119.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busgf119.c @@ -85,7 +85,8 @@ gf119_i2c_bus_new(struct nvkm_i2c_pad *pad, int id, u8 drive, { struct gf119_i2c_bus *bus;
- if (!(bus = kzalloc(sizeof(*bus), GFP_KERNEL))) + bus = kzalloc(sizeof(*bus), GFP_KERNEL); + if (!bus) return -ENOMEM; *pbus = &bus->base;
| |