lkml.org 
[lkml]   [2023]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1 5/5] riscv: dts: starfive: Add JH7110 PWM-DAC support
From
On Mon, 26 Jun 2023 17:37:35 +0200, Krzysztof Kozlowski wrote:
> On 26/06/2023 13:09, Hal Feng wrote:
>> Add PWM-DAC support for StarFive JH7110 SoC.
>>
>> Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
>> ---
>> .../jh7110-starfive-visionfive-2.dtsi | 50 +++++++++++++++++++
>> arch/riscv/boot/dts/starfive/jh7110.dtsi | 13 +++++
>> 2 files changed, 63 insertions(+)
>>
>> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
>> index 19b5954ee72d..5ca66a65e722 100644
>> --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
>> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
>> @@ -36,6 +36,34 @@ gpio-restart {
>> gpios = <&sysgpio 35 GPIO_ACTIVE_HIGH>;
>> priority = <224>;
>> };
>> +
>> + pwmdac_dit: pwmdac-dit {
>> + compatible = "starfive,jh7110-pwmdac-dit";
>> + #sound-dai-cells = <0>;
>> + };
>> +
>> + sound {
>> + compatible = "simple-audio-card";
>> + simple-audio-card,name = "StarFive-PWMDAC-Sound-Card";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + simple-audio-card,dai-link@0 {
>> + reg = <0>;
>> + format = "left_j";
>> + bitclock-master = <&sndcpu0>;
>> + frame-master = <&sndcpu0>;
>> + status = "okay";
>
> Drop

OK.

>
>> +
>> + sndcpu0: cpu {
>> + sound-dai = <&pwmdac>;
>> + };
>> +
>> + codec {
>> + sound-dai = <&pwmdac_dit>;
>
> You said it is a transmitter, not a codec...

It is a dummy codec, also known as a dummy transmitter.

Best regards,
Hal

\
 
 \ /
  Last update: 2023-06-30 04:13    [W:0.047 / U:1.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site